OSD lab6 blog post

During this lab, I found that the Brave browser will fail to search or open the correct content for the two url:
  • "https://www.google.ca/search?q=dog cat"
  • "file:///Users/humphd/repos/browser-laptop/dog cat.txt"

they all have a space between dog and cat, and because of that, the browser will consider they are not a valid url. I tried to fix this bug.

I found when they check the url, they only trim the spaces at beginning and end. The space between dog and cat won't be replace or encoded as an url. So, I added the code.

And I wrote test cases:

As well as ran the unit test:

Comments

Post a Comment

Popular posts from this blog

My first post

I found a cool open source project on GitHub called "Detectron". It is a Facebook AI research project used for object detection. This project is started 5 days ago with 2 contributors but it has 14 issues need to be solved. The main written language is Python. The link:  https://github.com/facebookresearch/Detectron
Read more

OSD release 0.2 final post

Image
This was a valuable learning experience of working with the  issue  on Mozilla/devtools:  debugger.html . The issue was related to adding flow coverage for one of the type.js file. At beginning, I did not think it will be a hard process, just need to learned flow as I supposed to. However, it was actually not that easy because I ran into many troubles like figuring out the meaning of the code and make good adjustment for fixing. Thankfully, after I push my PR on GitHub,  here , Jason, the owner of debugger repo helped a lot. He fixed last three errors which really need deep understanding of the code. However, we all ran into the last problem, which is shown in the screenshots below, This error is tough because I am not sure what is it causing it. By doing some research, it might be flow itself causing the error. So, Jason asked me to created another PR just for debugging this error and merged other code to the master branch. Overall, my first contribution to...
Read more

OSD Release 0.3 final post

Image
When I try to fix this issue  in debugger.html, I found some other bugs. Both issues are related to the "Set directory root" menu button on the left side panel of the debugger. They are not in the issues tab. The first issue occurs when there is a webpack folder. When trying to set the sub directory to the root, the content of the folder will be missing, but when setting it up directly, the content is rendered. It happens because of the webpack has different url than the ordinary ones. Issue 1 - STR: Go to  https://firefox-debugger-example-react-js.glitch.me/ On the left panel, right click on "Webpack" folder and Click on "Set directory root" Then right click on "app" foler and Click on "Set directory root" ( notice the content is missing ). Issue 2 - STR: Go to  https://davidwalsh.name/ On the left panel, right click on "davidwalsh.name" and Click on "Set directory root" Then expand the subfol...
Read more